Skip to content
Snippets Groups Projects
Commit 3798050c authored by Maja Jabłońska's avatar Maja Jabłońska Committed by Martyna Wiącek
Browse files

Fix non_padded_namespace mistake

parent d02e1f5f
Branches
Tags
1 merge request!46Merge COMBO 3.0 into master
......@@ -42,7 +42,7 @@ class _NamespaceDependentDefaultDict(defaultdict[str, TorchtextVocab]):
def __missing__(self, namespace: str):
# Non-padded namespace
if any([match_namespace(namespace, npn) for npn in self._non_padded_namespaces]):
if any([match_namespace(npn, namespace) for npn in self._non_padded_namespaces]):
value = torchtext_vocab(OrderedDict([]))
else:
value = torchtext_vocab(
......
import unittest
from combo.data import Vocabulary
from combo.data.vocabulary import match_namespace
class VocabularyTest(unittest.TestCase):
def test_match_namespace(self):
self.assertTrue(match_namespace('*labels', 'test_labels'))
def test_dont_match_namespace(self):
self.assertFalse(match_namespace('*labels', 'test_something'))
def test_default_non_padded_namespace(self):
v = Vocabulary()
self.assertFalse(v.is_padded('test_labels'))
def test_empty_padded_namespace_is_padded(self):
padded_namespaces = ['padded_example']
non_padded_namespaces = ['non_padded_example']
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment