The design doc for llook/rlook was incorrect, swapping the semantics per the...

The design doc for llook/rlook was incorrect, swapping the semantics per the updated docs and swapping argument order for llook.

libwccl/ops/functions/bool/iterations/leftlook.cpp

@@ -8,7 +8,7 @@ bool LeftLook::iterate(
 	Wccl::Position &p,
 	const Wccl::FunExecContext &context) const
 {
-	for(int i = left; i <= right; ++i) {
+	for(int i = right; i >= left; ++i) {
 		p.set_value(i);
 		if(evaluating_expr_->apply(context)->get_value()) {
 			return true;

libwccl/ops/functions/bool/iterations/leftlook.h

@@ -6,8 +6,9 @@
 namespace Wccl {
 
 /**
- * Iterative operator "llook", which looks for a first
- * position from left that makes evaluating expression return true.
+ * Iterative operator "llook", which looks for the rightmost position
+ * in a range that makes the evaluating expression return true, i.e.
+ * it "looks to the left".
  */
 class LeftLook : public Iteration
 {
@@ -30,12 +31,12 @@ public:
 
 protected:
 	/**
-	 * @returns True if, when scanning from left,
-	 * a position within range is found that makes
+	 * @returns True if, when scanning right-to-left,
+	 * a position within the range is found that makes
 	 * the evaluating function return true. False
 	 * otherwise.
 	 * @note Upon success, the iteration variable is
-	 * set to the first position in range from left
+	 * set to the rightmost position in range
 	 * that has made evaluation function return true
 	 * (that is the position that made the stop condition
 	 * true in this case).

libwccl/ops/functions/bool/iterations/rightlook.cpp

@@ -8,7 +8,7 @@ bool RightLook::iterate(
 	Wccl::Position &p,
 	const Wccl::FunExecContext &context) const
 {
-	for(int i = right; i >= left; --i) {
+	for(int i = left; i <= right; ++i) {
 		p.set_value(i);
 		if(evaluating_expr_->apply(context)->get_value()) {
 			return true;

libwccl/ops/functions/bool/iterations/rightlook.h

@@ -6,8 +6,9 @@
 namespace Wccl {
 
 /**
- * Iterative operator "rlook", which looks for a first
- * position from right that makes evaluating expression return true.
+ * Iterative operator "rlook", which looks for the leftmost position
+ * in a range that makes the evaluating expression return true, i.e.
+ * it "looks to the right".
  */
 class RightLook : public Iteration
 {
@@ -30,12 +31,12 @@ public:
 
 protected:
 	/**
-	 * @returns True if, when scanning from right,
-	 * a position within range is found that makes
+	 * @returns True if, when scanning left-to-right,
+	 * a position within the range is found that makes
 	 * the evaluating function return true. False
 	 * otherwise.
 	 * @note Upon success, the iteration variable is
-	 * set to the first position in range from right
+	 * set to the leftmost position in range
 	 * that has made evaluation function return true
 	 * (that is the position that made the stop condition
 	 * true in this case).

libwccl/parser/grammar.g

@@ -1078,9 +1078,9 @@ bool_iteration
 		RPAREN {
 			ret.reset(new AtLeast(lpos, rpos, *pacc, expr, min_match));
 		}
-	| "llook" LPAREN
-			lpos = position_operator [tagset, vars] COMMA 
+	| "llook" LPAREN //note inverted rpos/lpos order
 			rpos = position_operator [tagset, vars] COMMA
+			lpos = position_operator [tagset, vars] COMMA
 			pacc = position_variable_acc [vars]     COMMA
 			expr = bool_operator     [tagset, vars] 
 		RPAREN {